Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a GitHub Action to get all contracts #3663

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add a GitHub Action to get all contracts #3663

merged 1 commit into from
Oct 31, 2024
+53 −0

Conversation

turbolent
Copy link
Member

Description

Add a separate GitHub Action that allows getting all contracts for a chain, extracted from the existing backward compatibility checking action, i.e. re-using the get-contracts tool.

Also, include the contracts in the backward compatibility checking actions' artifacts.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz October 30, 2024 22:36
@github-actions GitHub Actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 1b27cc3
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent merged commit a56e521 into master Oct 31, 2024
10 of 12 checks passed
@turbolent turbolent deleted the bastian/get-contracts-action branch October 31, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@jsproz jsproz Awaiting requested review from jsproz

Assignees
No one assigned
Labels
Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS